[ts-command-line] Deprecate onDefineParameters.#4716
Merged
iclanton merged 7 commits intomicrosoft:mainfrom May 16, 2024
Merged
[ts-command-line] Deprecate onDefineParameters.#4716iclanton merged 7 commits intomicrosoft:mainfrom
iclanton merged 7 commits intomicrosoft:mainfrom
Conversation
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
…ainder parameter to the constructor
iclanton
commented
May 16, 2024
...nges/@rushstack/ts-command-line/ts-command-line-recommendation-updates_2024-05-15-20-16.json
Outdated
Show resolved
Hide resolved
iclanton
force-pushed
the
ts-command-line-recommendation-updates
branch
from
f29c7d5 to
7574a1d
Compare
D4N14L
approved these changes
May 16, 2024
iclanton
force-pushed
the
ts-command-line-recommendation-updates
branch
from
ded8bbd to
a42d8d1
Compare
D4N14L
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See #4708 (comment).
This PR marks
onDefineParametersas@deprecatedbecause it causes issues when targeting >=es2022.@D4N14L - This is probably still an issue for scoped parameters.
How it was tested
Updated tests.
Impacted documentation
README and API docs need to be republished.